https://bugzilla.redhat.com/show_bug.cgi?id=1058623
--- Comment #1 from Petr Šabata <[email protected]> --- FIX: Missing the perl(Data::Dumper) BR, from lib/WebService/Linode/Base.pm:10 and t/01-domains.t:4 FIX: Remove the JSON and LWP::UserAgent from the explicit runtime deps. Those will be picked up automatically. TODO: Add `perl' to your BRs as it's called in the SPEC. TODO: Package `examples' in the %doc. NOTE: I think it'd be better to require perl(LWP::Protocol::https) instead of the perl(Mozilla::CA) and perl(Crypt::SSLeay) combo, however I know you're just following the upstream's recommendation. Perhaps try if the module works with LWP::Protocol::https only and suggest the switch to upstream if you feel like it? In my opinion it'd be a bit cleaner. Anyhow, this really isn't important for the review and I haven't checked whether this makes any sense either :) Just a thought. Fix the points marked as FIX and I'll approve the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
