https://bugzilla.redhat.com/show_bug.cgi?id=1055730
--- Comment #1 from Mohamed El Morabity <[email protected]> --- Some comments: - same issue than in vdr-tvguide review: since the package is written in C++, and since the CXXFLAGS variable is handled by the plugin Makefile, you must also set CXXFLAGS when calling make, to keep consistency on build flags: make CFLAGS="%{optflags}" CXXFLAGS="%{optflags}" ... You should even add -fPIC to both CFLAGS and CXXFLAGS to handle build issues on x86_64 platforms. - the scripts deployed in %{vdr_configdir}/plugins/iptv/ can be called from channels.conf when an IPTV channel is selected from VDR. Most of them are demo scripts; they must be modified/copied to fit users' needs. I wonder if it's worth marking them as %config(noreplace) so these scripts wouldn't be overwritten by further updates if they were modified. Notice it's not a must, only a suggestion. - among those scripts, vlc2iptv contains a bad path to channels.conf. This script should probably be modified to refer to the right path to channels.conf, as defined by Fedora: %prep %setup -q -n %{vdr_plugin}-%{version} # Fix paths in plugin scripts sed -i "s|^CHANNELS_CONF=.*|CHANNELS_CONF=%{vdr_configdir}/channels.conf|; \ s|^CHANNEL_SETTINGS_DIR=.*/iptv|CHANNEL_SETTINGS_DIR=%{vdr_configdir}/plugins/%{vdr_plugin}|" \ iptv/vlc2iptv -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
