https://bugzilla.redhat.com/show_bug.cgi?id=1059708



--- Comment #4 from Marc-Andre Lureau <[email protected]> ---
(In reply to Michael Scherer from comment #3)
> Also : 
> - BuildRoot is no longer needed
> - %clean
> rm -rf %{buildroot} , the rm at start of install and %defattr are also
> uneeded for newer fedora
> 
> - chezdav and the spice subpackage do have the same summary

ok

> - there is no service file, while this is a daemon

added, but for some reasons, the daemon is not enabled automatically (although
it seems to work for vdagent), I am trying to figure out...

> - the spice subpackage should have the lciense in %doc as well, since it can
> be install without pulling chezdav


ok

See last update
Spec URL: http://elmarco.fedorapeople.org/phodav.spec

elmarco@anakao:~/pkg/phodav (master #%)$ rpmlint phodav.spec
~/rpmbuild/RPMS/x86_64/phodav-*
phodav-chezdav.x86_64: W: spelling-error %description -l en_US mDNS -> mans,
mdse
phodav-spice.x86_64: W: spelling-error %description -l en_US virtio -> virtuoso
phodav-spice.x86_64: W: only-non-binary-in-usr-lib
phodav-spice.x86_64: W: no-manual-page-for-binary spice-webdavd
3 packages and 1 specfiles checked; 0 errors, 4 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to