https://bugzilla.redhat.com/show_bug.cgi?id=1061801
Bug ID: 1061801
Summary: Review Request: gmic - GREYC's Magic for Image
Computing
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected]
Spec URL: http://berrange.fedorapeople.org/review/gmic/gmic.spec
SRPM URL:
http://berrange.fedorapeople.org/review/gmic/gmic-1.5.8.2-1.fc20.src.rpm
Description: G'MIC is an open and full-featured framework for image processing,
providing
several different user interfaces to convert/manipulate/filter/visualize
generic image datasets, from 1d scalar signals to 3d+t sequences of
multi-spectral volumetric images.
Fedora Account System Username: berrange
Some points to note
- A F21 rawhide build
http://koji.fedoraproject.org/koji/taskinfo?taskID=6494231
- Error from rpmlint:
$ rpmlint gmic.spec
gmic.spec:78: E: hardcoded-library-path in %{_prefix}/lib/*
0 packages and 1 specfiles checked; 1 errors, 0 warnings.
It is catching the place where the spec *fixes* the broken libdir from the
Makefile, so a false positive
- Warnings from rpmlint on the binaries:
$ rpmlint ~/rpmbuild/RPMS/x86_64/gmic-*1.5.8.2-1.fc20.x86_64.rpm
gmic.x86_64: W: spelling-error %description -l en_US datasets -> data sets,
data-sets, databases
gmic.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti
gmic.x86_64: W: spelling-error %description -l en_US volumetric -> cliometric
gmic.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/gmic
gmic-devel.x86_64: W: spelling-error %description -l en_US datasets -> data
sets, data-sets, databases
gmic-devel.x86_64: W: spelling-error %description -l en_US multi -> mulch,
mufti
gmic-devel.x86_64: W: spelling-error %description -l en_US volumetric ->
cliometric
gmic-devel.x86_64: W: no-documentation
gmic-gimp.x86_64: W: spelling-error %description -l en_US datasets -> data
sets, data-sets, databases
gmic-gimp.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti
gmic-gimp.x86_64: W: spelling-error %description -l en_US volumetric ->
cliometric
gmic-gimp.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 12 warnings.
I believe these are false positives because
* The spelling-errors are not errors.
* The lack of docs is fine since those sub-rpms depend on the main RPM which
has the COPYING file
* The bash completion files aren't supposed to be marked %config
- The GMIC code would ordinarily prefer to build with ffmpeg library support.
ffmpeg is of course not distributed in Fedora, so that is *not* done. When
ffmpeg is not available to compile against, GMIC code will instead fallback
to running the ffmpeg command line tools if they happen to be installed. If
the cli tools aren't present the functionality will raise an error. Since
this still only affects a tiny subset of GMIC functionality, I believe this
is a negligible limitation which doesn't outweigh benefits of including
GMIC in Fedora.
Oh, and yes, if you try to rebuild the srpm it will burn your CPU at 100% for a
pretty long time :-)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review
