https://bugzilla.redhat.com/show_bug.cgi?id=1066176
Matthew Miller <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1066359 --- Comment #2 from Matthew Miller <[email protected]> --- I ran into a basic showstopper because this depends on pkgconfig(libgsystem), and it looks like libgsystem is Not Yet A Thing. Other things: Since you don't have an upstream source URL, you should precede that line with a comment explaining how to generate the tar.xz. See https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL The %clean section and rm -rf $RPM_BUILD_ROOT aren't needed unless this is going into EPEL 5. For Fedora and newer epel, these are unneeded. Ditto %defattr. There is no %changelog. We need one. Need require systemd, because of the .service file. (More specifically, for the ownership of the directory that file goes in.) Very minor: I'd like to see the Summary be a little more descriptive. And, currently, doesn't seem to mention OpenStack in either the summary or description. Also: your COPYING File has the wrong address for the FSF. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1066359 [Bug 1066359] Review Request: libgsystem - GIO-based library with Unix/Linux specific API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
