https://bugzilla.redhat.com/show_bug.cgi?id=1065562
Christopher Meng <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #4 from Christopher Meng <[email protected]> --- (In reply to James Slagle from comment #3) > I've reviewed the updated spec (thanks!). I'm doing an unofficial review. > > I have a question for other reviewers. The %check in the spec downloads > paramiko from pypi since it's listed in the install_requires in setup.py. Is > this Ok, or does it violate: > > Must: Python eggs must not download any dependencies during the build > process. > > I wasn't sure if this meant %build specifically, or the entire rpmbuild. > > If so, python-paramiko should be added to the BuildRequires as well so that > when %check is run, pypi isn't used. Yes, you are right. And because koji doesn't have the internet connection, the check will fail. Orion, please fix all issues based on James pointed out, and then I will review it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
