https://bugzilla.redhat.com/show_bug.cgi?id=1067665
Parag AN(पराग) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #2 from Parag AN(पराग) <[email protected]> --- If this is going to be packaged for Fedora branches only then first change the spec to be compatible with current Fedora packaging guidelines. 1) Group is optional now so remove following line from spec Group: User Interface/X 2) Buildroot tag is not required now, remove it. See https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag 3) In %install removal of buildroot is not needed now. See https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Remove following line from spec rm -rf %{buildroot} 4) %clean is not required. See vhttps://fedoraproject.org/wiki/Packaging:Guidelines#.25clean 5) You don't need to write %defattr now. See last line of this section https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions 6) %makeinstall is NOT allowed to be used. See https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used Use following make install DESTDIR=%{buildroot} INSTALL="install -p" This will also preserve timestamps of files directly being copied from source in binary rpm. 7) When you use autoreconf in %prep that mean you should add BuildRequires: automake autoconf 8) your make command should be make %{?_smp_mflags} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
