https://bugzilla.redhat.com/show_bug.cgi?id=1059659
--- Comment #2 from Christopher Meng <[email protected]> --- 1. %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %endif Will you support EPEL5? If not please remove this. 2. %if (0%{?fedora} > 12 || 0%{?rhel} > 6) %global with_python3 1 %endif Well, who told you that RHEL7 has python3? 3. Summary: A Python library for parsing ISO 8601 strings For python 2 package, you can enhance it: Summary: Python 2 library for parsing ISO 8601 strings For python 3 package, do it again: Summary: Python 3 library for parsing ISO 8601 strings Thus please don't use Summary: %{summary}. 4. %description Library, implemented in pure Python, for parsing date strings in ISO 8601 format into datetime format. Well: This is a Python 2 library for parsing date strings in ISO 8601 format into datetime format. For python 3 package: This is a Python 3 library for parsing date strings in ISO 8601 format into datetime format. 5. %{python_sitelib} --> %{python2_sitelib} 6. Once you determine to support RHEL6, please add overrides: %if 0%{?rhel} && 0%{?rhel} <= 6 %{!?__python2: %global __python2 /usr/bin/python} %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} %endif 7. Please delete the egginfo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
