https://bugzilla.redhat.com/show_bug.cgi?id=1063040

Mo Morsi <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #1 from Mo Morsi <[email protected]> ---
Taking this one

Some minor style issues:

- In files list the spec dir, Gemfile, Rakefile, and gemspec should be marked
as %doc

- On same not marking files as %doc in the 'doc' subpackage is a bit redundant,
though not against guidelines

- Seem to be a bit of extraneous whitespace, consider tidying up

Package does not build in Koji:

http://koji.fedoraproject.org/koji/taskinfo?taskID=6556112

You are trying to use rspec in the %check section w/out listing that as a build
requirement. Also I believe your going to need to list the eventmachine
dependency as a build requirement so that the test suite fully functions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to