Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600467 Steve Traylen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Steve Traylen <[email protected]> 2010-06-08 14:18:24 EDT --- This is an informal review, as I understand from a mail you are seeking sponsership and should block this bug on FE-NEEDSPONSER accordingly. Just looking at the .spec file for now 1) The .la should be removed somehow. See: http://fedoraproject.org/wiki/PackagingGuidelines#Packaging_Static_Libraries 2) Your release tag is 2.1 which is odd, it typically starts at 1. :-) See: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Version In a nutshell it's the number of .spec file modifications or builds in fact since the Version was last update. 3) Not important I would say but in principal packages take the name of the tar ball so JAGS but I would never not approve based on that. http://fedoraproject.org/wiki/Packaging:NamingGuidelines 4) BuildRequires: gcc-c++ certainly is not needed, see http://fedoraproject.org/wiki/PackagingGuidelines#Exceptions_2 5) I see you have a .tex file in your docs have you considered converting it to something more readable such as ps or pdf. Steve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
