Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593851

--- Comment #5 from Richard Fearn <[email protected]> 2010-06-08 14:44:21 
EDT ---
> Richard, the package looks almost fine to me. I suggest to explicitly assign
> values to BINDIR and MANDIR in "make rpminstall", e.g.
>   make BINDIR=%{buildroot}%{_bindir} \
>        MANDIR=%{buildroot}%{_mandir}/man1 \
>        rpminstall  
> to ensure the files will be installed in the proper (rpm-defined) 
> directories.    

Good suggestion - given that the "rpminstall" target only uses BINDIR/MANDIR*,
it certainly makes things clearer.

* I remove the doc file install (which uses DOCDIR) in clide-Makefile.patch.

New spec/SRPM:

http://richardfearn.fedorapeople.org/clide/0.9-3/clide.spec
http://richardfearn.fedorapeople.org/clide/0.9-3/clide-0.9-3.fc13.src.rpm

Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to