https://bugzilla.redhat.com/show_bug.cgi?id=1070406
--- Comment #2 from Christopher Meng <[email protected]> --- I started from packaging it in 8.53, but then stopped as I had no time. Initial comments: 1. No static libraries please. 2. %qmake_qt4 should be used instead of the one you are using, as missing some FLAGS. 3. -docs --> doc 4. Requires: %{name} = %{version}-%{release} --> Requires: glib2-devel Requires: %{name}{?_isa} = %{version}-%{release} Requires: glib2-devel{?_isa} 5. Where is libproxy dep? 6. BuildRequires: qt-devel --?> BuildRequires: qt4-devel Just a cosmetic change. 7. %description %{summary}. No, that's too short, please igve some love here. 8. You remove group tag in the main package, good! But don't forget the one in -devel: Group: Development/Libraries 9.%{_sysconfdir}/signond.conf --> %config(noreplace) %{_sysconfdir}/signond.conf 10. %{_datadir}/doc --> %{_docdir} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
