https://bugzilla.redhat.com/show_bug.cgi?id=1069882
--- Comment #6 from Steven Dake <[email protected]> --- Angus, Couple things First your patches are directory diffs, which is ok, but IMO it makes more sense to do the following: clone a copy of the ironicclient. Apply the 0001 patch git commit -a (Write a nice changelog) Apply the 0002 patch git commit -a write a nice changelog git format-patch -2 This will give you a tidy changelog in the patches and allow people to use git am to apply the patches. The first patch will look at the variable: REDHATIRONICCLIENTVERSION I believe this needs to be sed-ed into the file as is done in the nova client spec file. I recently did this for one of the os-*-* tools and it was necessary to do the sed, or the installed package doesn't work. The requirements for removing the pbr runtime requirement come from the openstack fedora developers - this is not something a typical python packager would do, so keep that in mind during further reviews of other people's packages. Just one minor nitpick as well, typically %doc goes at the top of the files section. Although this is not mandatory or documented, it is a typical common convention and since you need to remake packages, it might not hurt to fix that up. Regards -steve -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
