https://bugzilla.redhat.com/show_bug.cgi?id=875087
--- Comment #26 from Paul Cochrane <[email protected]> --- (In reply to Orion Poplawski from comment #25) > - You didn't bump release and add a new changelog entry for these changes. > I guess this hasn't be explicit, but I want it for any change to the spec. Sorry about that; have corrected this issue in the current update. > - You only need to run desktop-file-install, not both it and > desktop-file-validate, it will validate the desktop file. I've removed desktop-file-validate > - If you wanted, you could just do: > > # desktop files > %{datadir}/icons/hicolor/256x256/apps/ > %{_datadir}/applications/pbsclusterviz.desktop > > up to you. Have simplified these statements as recommended. > - You need to update the icon cache: > https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache I've added the relevant %post* commands. Hopefully they are in the correct location in the .spec file such that the %install, %file, etc. sections are in the expected order. The updated tarball, RPMs and spec file are at the following locations: - https://github.com/paultcochrane/pbsclusterviz/releases/download/v0.7a/pbsclusterviz-0.7a.tar.gz - https://github.com/paultcochrane/pbsclusterviz/releases/download/v0.7a/pbsclusterviz-0.7a-5.el6.noarch.rpm - https://github.com/paultcochrane/pbsclusterviz/releases/download/v0.7a/pbsclusterviz-0.7a-5.el6.src.rpm - https://github.com/paultcochrane/pbsclusterviz/releases/download/v0.7a/pbsclusterviz.spec Thanks again! Paul -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
