https://bugzilla.redhat.com/show_bug.cgi?id=1063048
Mo Morsi <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Mo Morsi <[email protected]> --- Hey Nitesh some comments: - Spec file name should be 'rubygem-eventmachine_httpserver.spec' - %description should be a bit more descriptive than "Simple http server." Unfortunately there is not alot by ways of documentation in this gem but perhaps you could just write a sentence or two describing what it is, how it relates to event machine and stuff like "faster than other web servers" "non-rfc-strict parser" etc (just wouldn't reference other web servers like "thin" or "mongrel" specifically) - The rspec command should be "rspec -Ilib spec" - The %{gem_instdir}/eventmachine_httpserver.gemspec.* files should be rm'd or excluded - The test dir and Rakefile should be rm'd, excluded, or marked as %doc - This package is missing a LICENSE file, it should be included -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
