https://bugzilla.redhat.com/show_bug.cgi?id=1075218
Igor Gnatenko <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Igor Gnatenko <[email protected]> --- Some quick notes from first glance: * make install DESTDIR=%{buildroot} would be %make_install * Source0: %{name}-%{version}.tar.gz I'd prefer if you will provide link to upstream releases on ftp or http or git * A configuration file is /etc/pam_ldap2krb.conf Should not be in description. Should be in README which installing to system. * Group: security Should not present if you have no plans for supporting you package for EL5 or EL6 (forget) * %{_sysconfdir}/* not good. please provide %{_sysconfdir}/pam_ldap2krb.conf * %{_libdir}/* not good. please provide something like upper. * Tue Mar 11 2014 Kazım SARIKAYA <[email protected]> there should be also version of package. * Requires: pam libconfuse krb5-workstation openldap I'm not sure that we really want to have this dependencies. Some from this should automatically be picked up by RPM. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
