https://bugzilla.redhat.com/show_bug.cgi?id=1063047

Mo Morsi <mmo...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nob...@fedoraproject.org    |mmo...@redhat.com



--- Comment #5 from Mo Morsi <mmo...@redhat.com> ---
Hey nitesh, few more things

- You need to include the full url to the spec and srpm in your comment for the
fedora-review tool to pick it up (eg the srpm is missing 'http://'

- Please rm, exclude, or mark the following files as %doc: Gemfile, Rakefile,
websocket.spec

- The package should have a copy of the MIT license, see
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

- Remember to bump the release / add a new changelog entry before re-uploading.
Also wouldn't hurt to put the url of the koji scratch build run w/ the latest
version of the package (though not required as the review will run it
theirselves)

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to