https://bugzilla.redhat.com/show_bug.cgi?id=1065685
--- Comment #10 from Vít Ondruch <[email protected]> --- >> - You don't exclude %{gem_cache}. > > Good catch, thanks. Fixed in -3. Can't confirm. * You should not mark tests as a %doc - And there are probably also other directories which should not be marked. * seds in %prep - I would move the seds (especially for the test suite) into %check and kept the originals untouched. - The rubygems seds are unnecessary IMO. And if they are needed, then just on EL6. There are different means to require files for test suite if needed. * "# Require rubygems during binary invocation" - There should be generated bin stubs by rubygems, hence these seds are not requires - The subsequent copies of binaries in %install sections are wrong from the same reasons. - Please check with the example the guidelines [1]. * Fix wrong shebang - The seds can be modified into oneline version, which would be more intuitive IMO. [1] https://fedoraproject.org/wiki/Packaging:Ruby#Building_gems -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
