https://bugzilla.redhat.com/show_bug.cgi?id=1077746
--- Comment #2 from Richard Hughes <[email protected]> --- > 1. SHOULD use arch'd dependency in -devel subpkg, use > Requires: %{name}%{?_isa} = %{version}-%{release} > instead of > Requires: %{name} = %{version}-%{release} Fixed. > 2. SHOULD omit deprecated tags > %defattr Fixed. > 3. SHOULD up build dep > BuildRequires: glib2-devel >= 2.16.1 > to > BuildRequires: glib2-devel >= 2.39 Fixed, and good catch. > 4. SHOULD track library soname in %files, I'd prefer: > %{_libdir}/libappstream-glib.so.1* > instead of: > %{_libdir}/*libappstream-glib*.so.* Fixed. > 5. SHOULD omit unused macro: > %define alphatag .20140318git Fixed. Thanks for the speedy review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
