https://bugzilla.redhat.com/show_bug.cgi?id=804125



--- Comment #25 from Gianluca Sforna <gia...@gmail.com> ---
(In reply to Christopher Meng from comment #24)
> 1. F20+ has solved this bug, you can drop these:
> 
> # we don't want to provide private python extension libs, snippet from:
> # http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering
> %{?filter_setup:
> %filter_provides_in %{python_sitearch}/.*\.so$ 
> %filter_setup
> }

great. Removed


> 
> 2. %package devel
> Summary:        Development files for %{name}
> Group:          Development/Libraries
> Requires:       %{name}%{?_isa} = %{version}-%{release}
> Requires:       cmake
> Requires:       python2-devel
> Requires:       boost-devel
> 
> %{?_isa} should be used for all Requires.

Are you sure? The relevant page does not mention it at all
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

> 
> 3. A software suite for chemical informatics, computational chemistry, 
> and predictive modeling
> 
> Missing a dot.
> 

Fixed

> 4. %{python_sitearch} --> %{python2_sitearch}

Fixed

> 
> 5. All Group tags can be dropped.

Fixed

> 
> 6. Project has moved to github, with a new version:
> 
> https://github.com/rdkit/rdkit/releases

Changed

Updated spec and srpm:
http://giallu.fedorapeople.org/rdkit-2013.09.2-1.fc20.src.rpm
http://giallu.fedorapeople.org/rdkit.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to