Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=563376 --- Comment #5 from Chen Lei <[email protected]> 2010-06-12 06:22:53 EDT --- (In reply to comment #4) > This is an old package and the spec file is well-structured. > But it failed to build a binary package: > https://koji.fedoraproject.org/koji/taskinfo?taskID=2244897 > The %configure command should be something like: > %configure --enable-libnotify \ > --enable-wget \ > --enable-iplookup \ > --enable-proxy %{?_with_plugin:--enable-plugin} > The fact that the plugin is disabled should be recorded in %changelog . > And please change the release number every time you modify your spec file. > And some comments should be added on why the plugin is disabled but the > building code remains in the spec file. Will be fixed in next realse > Requires(post): /sbin/ldconfig > Requires(postun): /sbin/ldconfig > The above lines are not necessary. This is still needed, e.g. {_libdir}/libpcmanx.so.0 > Though the plugin is now prevented from building, the naming of it is not > good. > Maybe 'mozilla-pcmanx' is better, with respect to existing similar packages. > This package is not pure mozilla plugin, it also contain some xulrunner compenents , see %file xulrunner-plugin -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
