https://bugzilla.redhat.com/show_bug.cgi?id=1069335



--- Comment #24 from Steven Dake <[email protected]> ---
Angus,

Strictly speaking this package meets the license guidelines by installing any
package installs common which installs license and readme.  I don't like to
leave things open to interpretation re licensing however in package reviews, so
I think it would make sense to add the license (and possibly the readme) to
each of the subpackages as %doc sections.

The rpmlint errors look fine, fedora-review gives a clean bill of health, and a
manual review of the package since its complex shows it looks to be in good
order.

I'll be happy to approve once the %doc is added to each subpackage.

Regards
-steve

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to