https://bugzilla.redhat.com/show_bug.cgi?id=1084865
Rich Mattes <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Rich Mattes <[email protected]> --- OK the package looks good now. This package is APPROVED. "bloom-generate" is still broken for me, but I tracked it down to rosdistro's egg-info/requires.txt also depending on distribute instead of setuptools. I'll build an update of python-rosdistro tonight with a similar fix to the one that you applied to bloom. Are you using rosdistro from the Fedora repositories? Or is it that you still have distribute installed from pip which quietly satisfies rosdistro's dependency as well? And for future reference, it's common practice to bump the dist tag and create a new changelog entry when making revisions to your package during the review. That way reviewers don't get confused as to "i thought i already downloaded and built -1." It's not uncommon to be on -4 or -5 of a package by the time it gets accepted into Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
