https://bugzilla.redhat.com/show_bug.cgi?id=1079436
--- Comment #11 from John Eckersberg <[email protected]> --- Previous issues: - The upstream source tarball does not match the source tarball in the srpm Looks good - Extra unneeded Requires? You reviewed and said it's ok, so fine by me - No provided egg info This was originally correct, I messed up. - Use of deprecated %{__python} macro Fixed, looks good. - No %check section for tests %check added, tests pass - Use of 'mv' does not preserve timestamps There's still one use of 'mv' in the spec file, but it's just to use the .example file into place as config. For this purpose the original timestamp of the example file doesn't really matter, so I'm fine with it staying like this. - Group should be "Applications/System", not "Application/System" (note extra 's') This is still incorrect I think the Group is the only remaining packaging nit. I still need to actually test the thing out and make sure it at least functionally works for me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
