https://bugzilla.redhat.com/show_bug.cgi?id=1085752



--- Comment #8 from MartinKG <[email protected]> ---
(In reply to Mohamed El Morabity from comment #7)
> (In reply to MartinKG from comment #6)
> > hope i translate it correct ?
> Perfectly, the release tag seems correct :). Just be careful, the date the
> snapshot was made is 2014/04/09, not 2014/04/10 (see
> https://github.com/jdsn/check-create-certificate/commit/
> d0971baf5d13e06aaa600581efe3adba6631e06a).

corrected

> Github provides a convenient way to retrieve a snapshot from its commit: you
> should use the source URL below to download the source archive corresponding
> to a given snapshot:
>   Source0:   
> https://github.com/jdsn/check-create-certificate/archive/%{commit}/%{name}-
> %{shortcommit}.tar.gz

corrected

> Since the COPYING file is installed through the %doc macro, you don't need
> anymore to deploy it manually in %install: you can drop the lines below:
>    mkdir -p ${RPM_BUILD_ROOT}/%{_docdir}/%{name}
>    install -m 644 COPYING ${RPM_BUILD_ROOT}/%{_docdir}/%{name}
> 
> At last, in %description: "existence", not "existance" ;)
done

Spec URL:
https://www.dropbox.com/s/cupn2ukc35omi09/check-create-certificate.spec

SRPM URL:
https://www.dropbox.com/s/blb27bx0v90c5hw/check-create-certificate-0.5-6.20140409gitd0971ba.fc20.src.rpm

%changelog
* Fri Apr 11 2014 Martin Gansser <[email protected]> -
0.5-6.20140409gitd0971ba
- corrected snapshotdate
- corrected source url
- corrected git command
- droped %%install command for doc file in %%install section
- correted spelling in %%description

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to