https://bugzilla.redhat.com/show_bug.cgi?id=1086231



--- Comment #1 from Tom Hughes <[email protected]> ---
Preliminary points:

* Needs an ExclusiveArch: %{nodejs_arches} noarch

* The second %setup is not needed

* The ">" in the %nodejs_fixdep lines is bogus and should be removed

* The %nodejs_fixdep for tap is not doing anything as that is already the
  version in package.json

* The bench.js file is for benchmarking and doesn't need to be installed

* The examples dir should be in %doc, not installed to the lib dir

* The test dir should not be installed

* There should be a %check to run the tests

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to