https://bugzilla.redhat.com/show_bug.cgi?id=1086217



--- Comment #1 from Tom Hughes <[email protected]> ---
Preliminary comments:

* Needs an ExclusiveArch: %{nodejs_arches} noarch

* The second %setup is not needed

* You're installing cli.js twice, once with the cp then overwriting
  it with the install

* Is there a reason for adding the -nodejs suffix to the installed binary?

* Need to ask upstream to add a proper copy of the license, and add one
  yourself until then

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to