https://bugzilla.redhat.com/show_bug.cgi?id=1089559
--- Comment #7 from Jeremy Newton <[email protected]> --- (In reply to Thomas Koch from comment #6) > My remarks on the SPEC: > > > URL: http://linrunner.de/en/tlp/tlp.html > Should be: http://linrunner.de/tlp Ah thanks! > > Requires: smartmontools > Is not mandatory for TLP to work, should be an optional dependency. I don't believe fedora has "optional" dependencies, so I'll remove this and make note of it in the description. > > Requires: %{_bindir}/on_ac_power > Is not needed (since 0.3.10 in fact, as stated in the docs). Ah I misread; I thought it said mandatory after 0.3.10. Thanks! > In case laptop-mode-tools is in the Fedora repos, there should be a > "Conflicts:" for it. laptop-mode-tools is not a part of the official repo, but I know that there are ones being distributed by third party vendors (e.g. http://www.samwel.tk/laptop_mode). I guess I can add a conflict for %{_sbindir}/laptop_mode, but I don't want to use a package name due to possible renaming or re-branding. I'll make these changes later today when I get home. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
