https://bugzilla.redhat.com/show_bug.cgi?id=1079064
Dridi Boukelmoune <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #9 from Dridi Boukelmoune <[email protected]> --- (In reply to Dennis Payne from comment #7) > SRPM: http://identicalsoftware.com/btbuilder/btbuilder-0.4.3-1.fc20.src.rpm When you update, your spec and srpm, please use the same pattern from this bug description: Spec URL: ... SRPM URL: ... This way, the fedora-review tool will get them both for sure. fedora-review automates the review process to some extent ;-) You can locally try it on your own submission to catch errors faster and get more familiar with the guidelines. > All non-gpl images have been removed. License updated to gplv3 to > accommodate some artwork from opengameart.org. You will need to fix this, and mention all the licenses for the package: => for instance "License: GPLv2 and GPLv3+" https://fedoraproject.org/wiki/Packaging:LicensingGuidelines > About the Changelog section, how many previous version should be kept there? > (Not that it matters yet.) I encourage you to bump the Release tag every time you submit a new version during the review. * date name <email> - version-3 - Updated the license for both code and assets * date name <email> - version-2 - Removed non-gpl images - Updated the license to GPLv3+ * date name <email> - version-1 - Initial spec It feels less confusing (for me) during reviews. > I believe I've addressed all the mentioned issues. Let me know if anything > else should be changed. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
