https://bugzilla.redhat.com/show_bug.cgi?id=1091659
--- Comment #2 from Dave Johansen <[email protected]> --- > 1. iwyu or this loooooooooong name? I was just trying to match the upstream name, but I agree that it's annoyingly long so I changed it to iwyu. > 2. Why cmake28? The upstream source said it was required, but I just tried it with 2.6 and it worked just fine, so I added a patch to use cmake 2.6. > 3. %cmake28 -DLLVM_LIB_PATH=/usr/lib/llvm .. > What about 64 bits arch? Fixed to use %{_libdir} and I noticed some missing BuildRequires when testing this change, so I added those as well. > 3. Drop rm -rf %{buildroot}, %clean. Sorry, I'm developing on EL6 and the rpmlint from there still warns about that sort of stuff. However, since I'm not intending on supporting EL5 (just Fedora and EL6), I removed those lines since they're not required and just clutter things up. > 4. %{buildroot}/ --> %{buildroot} I believe that I made the requested change (i.e. removed the / between %{buildroot} and %{_bindir}), but please let me know if there's something else. The updated .spec and source RPM can be found at: http://daveisfera.fedorapeople.org/iwyu_3.4/iwyu.spec http://daveisfera.fedorapeople.org/iwyu_3.4/iwyu-3.4-1.el6.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
