https://bugzilla.redhat.com/show_bug.cgi?id=1093406



--- Comment #2 from Pádraig Brady <[email protected]> ---
Please use the "LGPLv3" licence tag

Please add COPYING file (LGPL3) to %doc

Please remove the "Copyright" section from the description

Please consider adding a python3 version of the package on Fedora

Please use the standard %{_python2} macros etc.
To support those on RHEL6 add:
# see https://fedoraproject.org/wiki/Packaging:Python#Macros
%if 0%{?rhel} && 0%{?rhel} <= 6
%{!?__python2: %global __python2 /usr/bin/python2}
%{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif

Please consider adding a %check if easy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to