https://bugzilla.redhat.com/show_bug.cgi?id=1098625



--- Comment #4 from Pavel Alexeev (aka Pahan-Hubbitus) <[email protected]> ---
(In reply to Remi Collet from comment #3)
> (In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #1)
> > 1)
> > [!]: License field in the package spec file matches the actual license.
> >      Note: Checking patched sources after %prep for licenses. Licenses 
> > found:
> >      "PHP (v2.0)", "Unknown or generated". 181 files have unknown license.
> >      Detailed output of licensecheck in
> > /home/pasha/SOFT/Review/php-pear-Text-
> >      Wiki/1098625-php-pear-Text-Wiki/licensecheck.txt
> > 
> > File Text/Wiki/Render/Latex/Prefilter.php have statements about LGPL and PHP
> > licenses. Need clarification.
> 
> It will be very hard to get some fix for this package which is tag as
> "unmaintained" upstream.
> 
> Despite... I have tried to ping pear QA about this.
> 
> Digging in the git history.
> Reported long time ago as https://pear.php.net/bugs/12580
> See
> https://github.com/pear/Text_Wiki/commit/
> 21ce607014ae3445147be2e52ceacdca0ca7b503
> 
> So this seems a copy/paste/cleanup minor error.
> So I think correct License is really LGPLv2.
> 
> But we can wait a little for upstream feedback if you prefer.

It really seems as error. Meantime we should wait answer or may fire Legal flag
now.

> > 2)
> > [!]: Package does not own files or directories owned by other packages.
> >      Note: Dirs in package are owned also by:
> > /usr/share/pear/Text(php-phpunit-Text-Template)
> 
> php-phpunit-Text-Template is not required, so this is ok.
No, it is not ok. Then it should be used for directory presence, item:
[x]: Package requires other packages for directories it uses.
i have marked as Ok, but we can look at it in that angle.

> Also notice that Text_Template have now moved to /usr/share/php  (in
> rawhide).
Do you target your package only for rawhide?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to