https://bugzilla.redhat.com/show_bug.cgi?id=1099269



--- Comment #3 from Sam Wilson <[email protected]> ---
Spec URL:
http://cycloptivity.fedorapeople.org/drupal7-admin_theme/1.0-2/drupal7-admin_theme.spec
SRPM URL:
http://cycloptivity.fedorapeople.org/drupal7-admin_theme/1.0-2/drupal7-admin_theme-1.0-2.fc19.src.rpm

Thanks for the reviews guys.

@Parag
1. As Shawn pointed out this is from the Drupal guidelines
2. This is my mistake. The module SPEC template doesnt include a buildroot so
thats been removed.
3. As per Shawn's update we discussed this on drupal-devel and its a bug that
will be fixed via the Drupal release mechanism.

@Shawn
4. I missed that in the guidelines where its mentioned drupal7-rpmbuild
handling the PHP lang dep. I've now removed it.

5. Pure failure on my part. theme in name != drupal theme :) Its now a module
as expected.

Also, I will start running each scratch build against EPEL 6 rather than F21
since that's the intended target.

http://koji.fedoraproject.org/koji/taskinfo?taskID=6869385

Cheers,

Sam

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to