https://bugzilla.redhat.com/show_bug.cgi?id=1104746
--- Comment #3 from Michael Schwendt <[email protected]> --- > Spec URL: > http://people.redhahttp://people.redhat.com/jduncan/soscleaner/soscleaner.spec Spec URL: http://people.redhat.com/jduncan/soscleaner/soscleaner.spec During review, keep the "SRPM URL:" and "Spec URL:" lines up-to-date when you modify the package, so the fedora-review tool can be used. Consider running "fedora-review -b 1104746" to let that tool perform many helpful checks. The spec file is full of mistakes and pitfalls. > %define name soscleaner > %define version 0.1 > %define release 11 %{name}, %{version} and %{release} are implicitly defined by the "Name:", "Version:" and "Release:" tags, so it's very poor form to first define these macros only to have the tags redefine the macros afterwards. If you want these values at the top of the spec file, move the tags at the top. Easy as that. > %define unmangled_version 0.1 https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define > Source0: %{name}-%{unmangled_version}.tar.gz That's not an URL: https://fedoraproject.org/wiki/Packaging:SourceURL > Group: Applications Not a group listed in /usr/share/doc/rpm/GROUPS and the Group tag is optional nowadays. In case of doubt, remove the tag from the spec file: https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag > BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag > Prefix: %{_prefix} https://fedoraproject.org/wiki/Packaging:Guidelines#Relocatable_packages > Vendor: Jamie Duncan <[email protected]> > Packager: Jamie Duncan <[email protected]> https://fedoraproject.org/wiki/Packaging:Guidelines#Tags > %clean > rm -rf $RPM_BUILD_ROOT https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean > %files -f INSTALLED_FILES As smart as you may find this technique, it hides too much under the carpet. What about directory ownership, for example? Prefer listing files and directories in the %files section directly. Use wildcards where helpful. > %defattr(-,root,root) https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
