https://bugzilla.redhat.com/show_bug.cgi?id=1062542



--- Comment #18 from Dominik 'Rathann' Mierzejewski <domi...@greysector.net> ---
(In reply to Christopher Meng from comment #17)
> No sweat, I understand your logic now:
> 
> Here is my new %files section:
> 
> %doc COPYING
> %{_libdir}/libdatrie.so.*
> %exclude %{_pkgdocdir}/*.css
> %exclude %{_pkgdocdir}/*.html
> %exclude %{_pkgdocdir}/*.js
> %exclude %{_pkgdocdir}/*.png
> 
> %files devel
> %doc AUTHORS ChangeLog NEWS README*
> %{_pkgdocdir}/*.css
> %{_pkgdocdir}/*.html
> %{_pkgdocdir}/*.js
> %{_pkgdocdir}/*.png
> %{_includedir}/datrie/
> %{_libdir}/libdatrie.so
> %{_libdir}/pkgconfig/datrie-0.2.pc
> %{_bindir}/trietool*
> 
> Note that I don't want to put useless files for end users in main-pkg, I
> hope you can understand. Thus only the license file packaged in main-pkg.

That is OK. I personally like to read ChangeLogs and READMEs from time to time,
but that's not a review blocker.

> Is it OK? If so please set + on this review, thanks in advance.

Not quite. The %doc macro in -devel subpackage will put the listed files
in /usr/share/doc/libdatrie-devel instead of libdatrie. If you're putting the
HTML docs from -devel in /usr/share/doc/libdatrie, you should be consistent and
put all the docs there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to