https://bugzilla.redhat.com/show_bug.cgi?id=1111957



--- Comment #2 from Dan Vrátil <[email protected]> ---
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kinit.spec
SRPM URL:
http://dvratil.fedorapeople.org/kf5/review/kf5-kinit-4.100.0-2.fc20.src.rpm

> 1) License - src/kdeinit/proctitle.{h,cpp} are under BSD license.

Fixed

> 2) Shouldn't be libkdeinit5_klauncher.so in -devel subpackage? If not, then 
> the > library should be versioned.

Nope, it's technically a plugin, see for instance /usr/lib(64)/libkdeinit_*.

> 3) Rpmlint error - kf5-kinit.i686: E: missing-call-to-setgroups /usr/libexec
> /kf5/start_kdeinit - this is the same issue which was present in kf5-kcrash, 
> it's not a blocking issue, but should be reported and fixed in upstream.

Submitted patch to upstream (https://git.reviewboard.kde.org/r/119011/)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to