https://bugzilla.redhat.com/show_bug.cgi?id=1116552
--- Comment #2 from Christopher Meng <[email protected]> --- (In reply to Michael Schwendt from comment #1) > As much as you may like "sed -i …" based substitutions in files, be aware > that this road is not a safe one. If the match fails, nothing gets > substituted. Using patches is to be preferred, unless you add guards more > often than not to verify that the sed command has worked. If you prefer, I could change to awk. I do check my script everytime, from the spec, and also from the koji build.log. The reason of not using patch is that, I only write patch for the code, such build script could be easily fixed. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
