https://bugzilla.redhat.com/show_bug.cgi?id=1115846
NIWA Hideyuki <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |m --- Comment #2 from NIWA Hideyuki <[email protected]> --- Hi This is my informal review. I comment about the spec file etc. 1. Summary: SOCKS Perl module A detailed a little more explanation is necessary though a long explanation is unnecessary. For what is this used with what? 2. License: GPL+ or Artistic Whether Artistic is "Artistic 2.0" or "Artistic clarified"? https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing 3. Group: Development/Libraries Remove it, no need to keep it now. 4. Source0: http://www.cpan.org/modules/by-module/SOCKS/SOCKS-%{version}.tar.gz There is no source in the link. 5. BuildRequires: perl BuildRequires: perl(AutoLoader) BuildRequires: perl(Carp) BuildRequires: perl(Exporter) BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(IO::Socket) BuildRequires: perl(strict) BuildRequires: perl(vars) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) Are all necessary? The unnecessary should be erased. And, please add comments on explicit dependencies. 6. find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; It is dangerous rm in %install. Can this be deleted? 7. %{_fixperms} $RPM_BUILD_ROOT/* Why is this necessary? Can this be deleted? 8. Installed file (/usr/share/doc/perl-SOCKS/example) depends on "/usr/local/bin/perl". Isn't /usr/bin/perl correct? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
