https://bugzilla.redhat.com/show_bug.cgi?id=1096072
Parag AN(पराग) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #1 from Parag AN(पराग) <[email protected]> --- Review: + mock build is successful for f22 + rpmlint output on rpms gave nodejs-sprintf.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-sprintf.noarch: W: only-non-binary-in-usr-lib nodejs-sprintf.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 3 warnings. + Source verified with upstream as (sha256sum) srpm tarball :d77c7808d66a10a063eff55d36bb74ea383b84f219d42bb2378df031a2c89803 upstream tarball : d77c7808d66a10a063eff55d36bb74ea383b84f219d42bb2378df031a2c89803 + License "MIT" is valid and is included in its own file as %doc + rest looks following packaging guidelines Suggestions: 1) you can drop Group tag for Fedora releases. 2) Good to add following in %prep %nodejs_fixdep 3) Good to add following in %install %nodejs_symlink_deps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
