https://bugzilla.redhat.com/show_bug.cgi?id=1122247

Parag AN(पराग) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <[email protected]> ---
Review:

+ mock build is successful for f22.

- rpmlint output on rpms gave
nodejs-xregexp.noarch: W: spelling-error %description -l en_US natively ->
naively, negatively, tentatively
nodejs-xregexp.noarch: W: spelling-error %description -l en_US utils -> tills
nodejs-xregexp.noarch: W: spelling-error %description -l en_US regex -> regexp,
reg ex, reg-ex
nodejs-xregexp.noarch: W: spelling-error %description -l en_US lastIndex ->
last Index, last-index, clandestine
nodejs-xregexp.noarch: W: only-non-binary-in-usr-lib
nodejs-xregexp.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/nodejs-xregexp/README.md
nodejs-xregexp.src: W: spelling-error %description -l en_US natively ->
naively, negatively, tentatively
nodejs-xregexp.src: W: spelling-error %description -l en_US utils -> tills
nodejs-xregexp.src: W: spelling-error %description -l en_US regex -> regexp,
reg ex, reg-ex
nodejs-xregexp.src: W: spelling-error %description -l en_US lastIndex -> last
Index, last-index, clandestine
2 packages and 0 specfiles checked; 0 errors, 10 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball    
:294789d762922caca62fa1836789c3bc7822661f7b9f6e9c653a5ca6e4b6ad88
upstream tarball
:294789d762922caca62fa1836789c3bc7822661f7b9f6e9c653a5ca6e4b6ad88

+ License "MIT" is valid and is included in its own file as %doc

+ rest looks following packaging guidelines.

Suggestions:
1) Please fix rpmlint wrong-file-end-of-line-encoding warning before package
import.

2) Include MIT-LICENSE.txt as %doc file.

Observed that .js file also having all lines ending ^M character.


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to