https://bugzilla.redhat.com/show_bug.cgi?id=1121085
František Dvořák <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #1 from František Dvořák <[email protected]> --- Hello, I'm still a newbie in ruby packaging, but I'll try the review... I've noticed the development files (Rakefile, Gemfile, ...) are in -doc subpackage. I guess this is up to packager, what to do with the files? Or is there any recommendation? Alternative ways are: - %exclude them - remove and patched them out in %prep I guess nothing needs to be changed here. (In my package #1076976 I used the patching.) Issues/notices: 1) the spec file is different from .src.rpm 2) W: macro-in-comment %check (line 58) --> But it is already fixed in the separate .spec file. 3) extra spaces at end of lines 13 and 25 :-) 4) * E: script-without-shebang /usr/share/gems/gems/pundit-0.2.3/lib/generators/pundit/policy/templates/policy.rb I guess this file should not be executable? Could you review swap for #1076976 rubygem-settingslogic? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
