https://bugzilla.redhat.com/show_bug.cgi?id=1045676
--- Comment #4 from František Dvořák <[email protected]> --- 1) there is hardcoded upstream version in main.c as 0.1 ==> the main version should be 0.1 instead and the snapshot version should be only in the release tag 2) group: not needed, if not packaged for EPEL 3) better would be to use %doc sunwait.html (in that case there is needed to copy %{SOURCE1} in %prep), another advantage will be you won't need _pkgconfigdir macro 5) license is "or later", so the license field should be "GPLv2+" 6) packages should contain man pages for all binaries/scripts. If it doesn't, work with upstream to add them. http://fedoraproject.org/wiki/Packaging:Guidelines#Man_pages It is not strictly required and no show-stoper for the review. But it could help users to have it (describing thet the utility will wait by default, ...) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
