https://bugzilla.redhat.com/show_bug.cgi?id=1077301
Yajo <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Yajo <[email protected]> --- > Fixed! SRPM and SPEC updated. Please update %changelog even for review updates. > %define modname aaargh Please use %global. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25global_preferred_over_.25define > %doc LICENSE.rst Please add README.rst too. Upstream provides tests, so a %check section would be good. Always remember to pass the built packages through rpmlint to fix them as much as possible. Right now it says: python-aaargh.noarch: W: spelling-error %description -l en_US subcommand -> sub command, sub-command, commandant python-aaargh.noarch: W: incoherent-version-in-changelog 0.7-1 ['0.7.1-1.fc20', '0.7.1-1'] python3-aaargh.noarch: W: spelling-error %description -l en_US subcommand -> sub command, sub-command, commandant 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Also, a personal suggestion: is there any reason for all the `with_python3` stuff? If not, just simplify your life: always build both packages. Please note that this is an unofficial review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
