Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=595638 Kalev Lember <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review? --- Comment #1 from Kalev Lember <[email protected]> 2010-06-26 15:32:00 EDT --- Taking for review. > Summary: Qt4 cross-platform client for Twitter I think it's better to avoid mentioning the toolkit (Qt4) in summary, but rather concentrate on what the client does. It's really not interesting for non-technical users. Also, I wouldn't say "cross-platform" either, as it basically just says that we can run that program. I'd suggest to use the summary from Debian package [1] instead: "Lightweight desktop client for Twitter microblogging service" [1] http://packages.debian.org/sid/qwit Why aren't you using the cmake-based build system instead of qmake? The CMakeLists.txt file looks pretty sophisticated and among other things installs translation files automatically, which are currently missing from the rpm. Instead of installing the icon directly to %{_datadir}/icons/*.png, I think it'd be better to install it to %{_datadir}/icons/hicolor/*/apps/*.png as the latter supports icon themes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
