https://bugzilla.redhat.com/show_bug.cgi?id=823679



--- Comment #10 from Lubomir Rintel <[email protected]> ---
0.) rpmlint unhappy:

python-pdfminer.src:17: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab:
line 17)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

1.) You don't need to quote your name with single quotes in changelog:


* Sat Aug 16 2014 'Ben Rosser' <[email protected]> 20140328-0

2.) Please move the files only after actual install in %{buildroot}.

This makes %install non-idempotent and thus breaks short-circuit of install
phase (rpmbuild -bi --short-circuit).

%install
...
# Rename the python scripts to get rid of the *.py suffix
mv build/scripts-2.7/dumppdf.py build/scripts-2.7/dumppdf
mv build/scripts-2.7/pdf2txt.py build/scripts-2.7/pdf2txt
mv build/scripts-2.7/latin2ascii.py build/scripts-2.7/latin2ascii

3.) The initial release number should be >= 1.

Release numbers < 1 are reserved to pre-release snapshots.

Release:        0%{?dist}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to