https://bugzilla.redhat.com/show_bug.cgi?id=1132671



--- Comment #3 from Vít Ondruch <[email protected]> ---
* The .spec differences
  - The .spec file you posted differs from the one included in SRPM. It is just
    small difference in you name in %changelog, so no big deal.

* Update to the latest guidelines
  - The .spec file looks to be generated by old gem2rpm and does not conform
    to the latest Ruby packaging guidelines. Please remove the Requires, which
    are now autogenerated and Provides.

* Test suite is not executed.
  - Please execute the test suite.
  - Although it is not shipped with the gem, it is available upstream [1].

* Move VERSION file into the main package
  - It seems to be runtime dependency. It is read by
    lib/compass/import-once/version.rb


[1] https://github.com/Compass/compass/tree/stable/import-once/test

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to