https://bugzilla.redhat.com/show_bug.cgi?id=1135151



--- Comment #5 from Andrew Beekhof <[email protected]> ---
(In reply to David Vossel from comment #4)
> Package looks good, here are a few things I found.
> 
> - license. GPL-2.0+ is typically written GPLv2+ 

done

> 
> - release. we typically use the %{?dist} tag

done

> 
> - the rpm built fine. There were some warnings at the beginning that were
> curious though.
> 
> [dvossel ~]$ rpmbuild --rebuild sbd-1.2.1-0.2.8f91294.git.src.rpm 
> Installing sbd-1.2.1-0.2.8f91294.git.src.rpm
> warning: user beekhof does not exist - using root
> warning: group beekhof does not exist - using root
> warning: user beekhof does not exist - using root
> warning: group beekhof does not exist - using root

Those are just because I built the src.rpm with my local account.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to