https://bugzilla.redhat.com/show_bug.cgi?id=1139009

Emmanuel Seyman <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: perl-LV -   |Review Request: perl-LV -
                   |LV ♥ lvalue                 |Perl module to make lvalue
                   |                            |subroutines easy and
                   |                            |practical



--- Comment #2 from Emmanuel Seyman <[email protected]> ---
(In reply to Petr Šabata from comment #1)
>
> Could we get a more descriptive summary?

Done.

> You could substitute PERL_INSTALL_ROOT with the standard DESTDIR.

Done.

> You could drop line 41; it's unnecessary nowadays.

Line 36 removed.

> You're missing some BRs, namely:
>  - Carp, lib/LV/Backend/Magic.pm:10, via 04magic.t
>  - Exporter, lib/LV.pm:16, via 01basic.t
>  - strict, used by everything
>  - Variable::Magic, lib/LV/Backend/Magic.pm:11, via 04magic.t -> lib/LV.pm:46
>  - warnings, used by everything

All added.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-LV/perl-LV.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-LV/perl-LV-0.006-2.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to