https://bugzilla.redhat.com/show_bug.cgi?id=1132971
--- Comment #10 from Matthew Booth <[email protected]> --- Very nice. I've re-reviewed and there are no longer any blockers. My sponsor status seems to be in limbo right now, which I'm chasing, but as soon as that's cleared up I'll approve this. I still have a couple of non-blocking recommendations: This doesn't need to be in there, as the package is noarch: %{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} You could simplify %files somewhat with: %{python_sitelib}/* in place of: %{python_sitelib}/*.egg-info %dir %{python_sitelib}/pyVmomi %dir %{python_sitelib}/pyVim %{python_sitelib}/pyVmomi/* %{python_sitelib}/pyVim/* (and the same for python3). These are equivalent in this package. I haven't seen this incantation before: %{!?_licensedir:%global license %%doc} but it looks kosher. It's clearly defined, as the license is installed to /usr/share/licenses, and for the same reason I assume that the warning about that directory not being packaged is bogus. However, you don't need to define it twice, which you are currently doing. You could move the declaration up to the top and remove it from both %files sections. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
