https://bugzilla.redhat.com/show_bug.cgi?id=1121355
--- Comment #6 from Robert Scheck <[email protected]> --- (In reply to Jared Smith from comment #5) > This package is looking pretty good, but isn't quite ready for approval. In > particular, please review the sources for code under other licenses, and use > the %global macro in your spec file instead of %define, unless there is a > specific reason not to. Eh, yes. The %define rather %global thing is due to history, no specific reason. I will change this. Checking patched sources after %prep for licenses is too early because the spec file removes some files and directories to unbundle some software. How did you do the license check exactly? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
